[ 
https://issues.apache.org/jira/browse/AMBARI-14171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037655#comment-15037655
 ] 

Hadoop QA commented on AMBARI-14171:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12775515/AMBARI-14171_branch-2.1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
contrib/views/hive.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/4465//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/4465//console

This message is automatically generated.

> Relocate Hive view UI 'polestar' and 'voyager' library dependencies
> -------------------------------------------------------------------
>
>                 Key: AMBARI-14171
>                 URL: https://issues.apache.org/jira/browse/AMBARI-14171
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-views
>    Affects Versions: Ambari-2.1.3
>            Reporter: DIPAYAN BHOWMICK
>            Assignee: DIPAYAN BHOWMICK
>             Fix For: Ambari-2.1.3
>
>         Attachments: AMBARI-14171_branch-2.1.patch
>
>
> Currently the 
> {{contrib/views/hive/src/main/resources/ui/hive-web/bower.json}} file has 
> below dependencies which are hosted in a private project. 
> {noformat}
>     "polestar": "https://github.com/pallavkul/polestar.git#0.7.1";,
>     "voyager": "https://github.com/pallavkul/voyager.git#0.7.1";
> {noformat}
> Unless the person is the author of the library, it is not advisable to keep 
> product code in personal repos. Due to this there are short-term and 
> long-term proposals which we can track here.
> Short-term: Move the fork to be hosted by [https://github.com/hortonworks]
> Long-term: Create JIRAs to see if we can contribute the overriding code back 
> to the base projects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to