----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40879/#review108852 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Dec. 2, 2015, 3:09 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40879/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 3:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-14161 > https://issues.apache.org/jira/browse/AMBARI-14161 > > > Repository: ambari > > > Description > ------- > > Enforce granular role-based access control for credential functions > > Entry points affected: > - GET /clusters/:cluster_name/credentials > - GET /clusters/:cluster_name/credentials/:alias > - POST /clusters/:cluster_name/credentials/:alias > - PUT /clusters/:cluster_name/credentials/:alias > - DELETE /clusters/:cluster_name/credentials/:alias > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java > 52783c9 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java > 43c9aa2 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java > 00ad412 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java > 9eaced1 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 0731cf7 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2a4c776 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 2492978 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 970231b > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4091b70 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql da756f7 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java > 5f32d39 > > ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java > 634d840 > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java > 09972a7 > > Diff: https://reviews.apache.org/r/40879/diff/ > > > Testing > ------- > > Manually tested - clean install, ugrade, enable Kerberos (uses credential > entry points) > > # Local test results: > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:00:55.637s > [INFO] Finished at: Wed Dec 02 14:39:27 EST 2015 > [INFO] Final Memory: 67M/921M > [INFO] > ------------------------------------------------------------------------ > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
