-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40916/
-----------------------------------------------------------
(Updated Dec. 4, 2015, 12:56 p.m.)
Review request for Ambari, Robert Levas, Robert Nettleton, Srimanth Gunturi,
and Sebastian Toader.
Changes
-------
use 2.2 branch instead of 2.1
Bugs: AMBARI-14177
https://issues.apache.org/jira/browse/AMBARI-14177
Repository: ambari
Description
-------
Blueprint provisioning with multiple Ranger KMS components is failed with the
following exception:
java.lang.IllegalArgumentException: Unable to update configuration property
'hadoop.kms.key.provider.uri' with topology information. Component
'RANGER_KMS_SERVER' is mapped to an invalid number of hosts '2'
1. 'hadoop.kms.key.provider.uri' property is dbks://http@localhost:9292/kms
(default) should work as it is internal for KMS. Its not needed to replace
'localhost'
2. HDFS client properties ( hadoop.security.key.provider.path,
dfs.encryption.key.provider.uri) are need to be updated (single host updater
startegy -> multiple host updater strategy)
3. stack advisor used wrong delimiter for the properties above. (based on:
http://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.3.0/bk_Ranger_KMS_Admin_Guide/content/ch_ranger_kms_multi_kms.html).
The Ambari UI also updates these properties if new Ranger KMS server added,
and also it replaces ',' with ';' (i found a story about the correct values on
UI: https://issues.apache.org/jira/browse/AMBARI-11613)
4. the patch contains fixes for handling suffix handling (it doesnt work with
multiple host topology updater, if the proerty string contains only one host):
- Use case with old code: "kms://http@%HOSTGROUP::group1%:2181/kms" -> (with
multiple host updater) "kms://http@host1:2181"
5. localhost' was not replaced in the multiple topology updater as well
(despite that, it was verified there) -> replace only if there is only one host
for the specific component.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
7f11bb9
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py
a33be1e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
17c0157
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py f5c0436
Diff: https://reviews.apache.org/r/40916/diff/
Testing
-------
Unit testing in progress..
Thanks,
Oliver Szabo
