-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41132/#review109495
-----------------------------------------------------------

Ship it!


Once you run the python tests you got my 'Ship it' :)

- Andrew Onischuk


On Dec. 9, 2015, 10:41 a.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41132/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 10:41 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Oliver Szabo.
> 
> 
> Bugs: AMBARI-14287
>     https://issues.apache.org/jira/browse/AMBARI-14287
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger admin HA installation fails when the cluster is deployed with a 
> Blueprint that has stack advisor enabled with:
> 'unicode' object has no attribute 'isempty'
> 
> Removed the isempty() function call as there is no such function on python 
> string. It's enough just to call strip() on the string and verify that is not 
> empty.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> f3e6f8b 
> 
> Diff: https://reviews.apache.org/r/41132/diff/
> 
> 
> Testing
> -------
> 
> Deployed a cluster of 3 nodes using Blueprint having Ranger Admin in HA mode 
> and cluster creation template with stack advisor enabled 
> ("config_recommendation_strategy" : "ALWAYS_APPLY").
> 
> Verified that ranger admin installed correctly and also the plugins 
> registered with ranger.
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Reply via email to