> On Dec. 9, 2015, 1:10 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml, > > line 79 > > <https://reviews.apache.org/r/40912/diff/2/?file=1153813#file1153813line79> > > > > This is clear now. In HDP 2.2, these properties in ranger-env had a > > different default value. > > xasecure.audit.destination.hdfs defaulted to false, and the new value > > in HDP 2.3 is true > > xasecure.audit.destination.db defaulted to true, and the new value in > > HDP 2.3 is false > > > > In order to preserve the current value of the property during RU from > > 2.2 to 2.3, the property needs to have the logic of > > false -> false, or true -> true, otherwise, forcefully setting it > > overrides the value, and no-op will merge will the new value in HDP 2.3
Thanks Alejandro, am closing this review request. - Gautam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40912/#review109435 ----------------------------------------------------------- On Dec. 4, 2015, 12:29 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40912/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 12:29 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: AMBARI-14169 > https://issues.apache.org/jira/browse/AMBARI-14169 > > > Repository: ambari > > > Description > ------- > > Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to > 2.3 after Smart Config changes. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml > 007f6a4 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 98e8e4f > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 88eb9ac > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > 54236cf > > Diff: https://reviews.apache.org/r/40912/diff/ > > > Testing > ------- > > Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of > properties. > ----------------------------------------------------------------------- > Ran 271 tests in 8.739s > > OK > ---------------------------------------------------------------------- > Total run:879 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Gautam Borad > >
