----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41204/#review109766 -----------------------------------------------------------
Ship it! Ship It! - Myroslav Papirkovskyy On Гру. 10, 2015, 4:19 після полудня, Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41204/ > ----------------------------------------------------------- > > (Updated Гру. 10, 2015, 4:19 після полудня) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav > Papirkovskyy, Nate Cole, Sumit Mohanty, Swapan Shridhar, and Sid Wagle. > > > Bugs: AMBARI-14298 > https://issues.apache.org/jira/browse/AMBARI-14298 > > > Repository: ambari > > > Description > ------- > > The RBAC changes attempt to perform authorization checks on resource-specific > identifiers. This is not the intended use of the authorization (admin*/auth*) > tables as the resource's adminresource id is to be looked up and an > authorization check is to be performed on that. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 3c66127 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > fdee605 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > b45ef72 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > 760dcbc > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > a356236 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 28af9cb > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java > 1b3e6f4 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 2c5c5af > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 911d8d7 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > 6d6cea6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java > 9b47bf7 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java > 4357a24 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProviderTest.java > c272f2b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java > dd8efa6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java > 7f99bb2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java > 34b674f > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java > b2a084a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > c99f631 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java > b3168f2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java > 1b1bdc3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java > fdcfbce > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java > 4321485 > > ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java > 8abe757 > > Diff: https://reviews.apache.org/r/41204/diff/ > > > Testing > ------- > > Manually tested > > # Local test results: PASSED > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
