----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41273/#review110033 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 320) <https://reviews.apache.org/r/41273/#comment169784> This is the significant change in this review. ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 393) <https://reviews.apache.org/r/41273/#comment169785> Moved this from install_packages.py to here since it looks cleaner. ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 525) <https://reviews.apache.org/r/41273/#comment169786> I wanted to explicitly use a string, either backup or current, to indicate where the symlink is going to. ambari-common/src/main/python/resource_management/libraries/script/script.py (line 272) <https://reviews.apache.org/r/41273/#comment169787> This is called by conf_select.py ambari-server/src/main/resources/custom_actions/scripts/install_packages.py <https://reviews.apache.org/r/41273/#comment169789> Moved this to conf_select.py - Alejandro Fernandez On Dec. 11, 2015, 10:45 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41273/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 10:45 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Jayush Luniya, and Nate Cole. > > > Bugs: AMBARI-14307 > https://issues.apache.org/jira/browse/AMBARI-14307 > > > Repository: ambari > > > Description > ------- > > * Ambari 2.2 at hash for AMBARI-14237 > (e15d1e0fb3777f79cb473cf5de0f7a6bf30e63bd) > * HDP 2.2.8.0 with HDFS, YARN/MR, ZK, Kafka > * RU from to 2.3.4.0 and reach the Finalize screen. > * Then downgrade, > > Kafka broker restart failed on downgrade > ``` > Traceback (most recent call last): > File > \"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py\", > line 39, in <module> > BeforeStartHook().execute() > File > \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\", > line 217, in execute > method(env) > File > \"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py\", > line 36, in hook > create_topology_script_and_mapping() > File > \"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/rack_awareness.py\", > line 69, in create_topology_script_and_mapping > create_topology_mapping() > File > \"/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/rack_awareness.py\", > line 36, in create_topology_mapping > group=params.user_group) > File \"/usr/lib/python2.6/site-packages/resource_management/core/base.py\", > line 154, in __init__ > self.env.run() > File > \"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", > line 158, in run > self.run_action(resource, action) > File > \"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", > line 121, in run_action > provider_action() > File > \"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py\", > line 144, in action_create > raise Fail(\"Applying %s failed, looped symbolic links found while > resolving %s\" % (self.resource, path)) > resource_management.core.exceptions.Fail: Applying > Directory['/etc/hadoop/conf'] failed, looped symbolic links found while > resolving /etc/hadoop/conf > Error: Error: Unable to run the custom hook script ['/usr/bin/python2', > '/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py', > 'START', '/var/lib/ambari-agent/data/command-2873.json', > '/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START', > '/var/lib/ambari-agent/data/structured-out-2873.json', 'INFO', > '/var/lib/ambari-agent/tmp'] > ``` > > > This failed because /etc/hadoop/conf is now a circular symlink > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > 7fd64b5 > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py > 7d90dca > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 398cee8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py > 6fcf08a > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 85d0d25 > > Diff: https://reviews.apache.org/r/41273/diff/ > > > Testing > ------- > > PRELIMINARY code review. Still need to test and fix unit tests. > > TODO: > 1. Fresh install > 2. EU from 2.1 to 2.3 > 3. RU from 2.2 to 2.3, and downgrade > 4. RU/EU from 2.2 to 2.2+ > 5. RU/EU from 2.3 to 2.3+ > > > Thanks, > > Alejandro Fernandez > >
