> On Dec. 15, 2015, 12:27 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py, > > lines 433-446 > > <https://reviews.apache.org/r/41138/diff/3/?file=1164848#file1164848line433> > > > > I'm wondering if we should also move this to keep it together with the > > `select` that was moved.
It couldn't hurt I suppose. This is only making sure we have a need to call create(). The only reason we have select() doing both is for ease of use by the common-services scripts. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41138/#review110508 ----------------------------------------------------------- On Dec. 15, 2015, 12:15 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41138/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 12:15 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, Jayush Luniya, and Nate Cole. > > > Bugs: AMBARI-14293 > https://issues.apache.org/jira/browse/AMBARI-14293 > > > Repository: ambari > > > Description > ------- > > During nightly run over Centos7 express upgrade test cases failed because of > TEZ Client issue. > > Restart of Tez Client failed after upgrade because of conf file missing. > > After logging on box I found the soft links /etc/tez/conf & > /usr/hdp/current/tez-client/conf pointing in loop to each other. > > [root@os-r7-test-2 tez-client]# ls -l /usr/hdp/2.3.4.0-3426/tez/conf > lrwxrwxrwx. 1 root root 13 Dec 8 05:05 /usr/hdp/2.3.4.0-3426/tez/conf -> > /etc/tez/conf > [root@os-r7-test-2 tez-client]# ls -l /etc/tez/conf > lrwxrwxrwx. 1 root root 32 Dec 8 02:23 /etc/tez/conf -> > /usr/hdp/current/tez-client/conf > [root@os-r7-test-2 tez-client]# ls -l /usr/hdp/current/tez-client/conf > lrwxrwxrwx. 1 root root 13 Dec 8 05:05 /usr/hdp/current/tez-client/conf -> > /etc/tez/conf > [root@os-r7-test-2 tez-client]# > > > Error on UI > {code} > Traceback (most recent call last): > File > "/var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py", > line 104, in <module> > TezClient().execute() > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 217, in execute > method(env) > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 486, in restart > self.pre_upgrade_restart(env, upgrade_type=upgrade_type) > File > "/var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py", > line 59, in pre_upgrade_restart > conf_select.select(params.stack_name, "tez", params.version) > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/conf_select.py", > line 247, in select > shell.checked_call(get_cmd("set-conf-dir", package, version), > logoutput=False, quiet=False, sudo=True) > File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", > line 70, in inner > result = function(command, **kwargs) > File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", > line 92, in checked_call > tries=tries, try_sleep=try_sleep) > File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", > line 140, in _call_wrapper > result = _call(command, **kwargs_copy) > File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", > line 291, in _call > raise Fail(err_msg) > resource_management.core.exceptions.Fail: Execution of 'conf-select > set-conf-dir --package tez --stack-version 2.3.4.0-3426 --conf-version 0' > returned 1. /usr/hdp/2.3.4.0-3426/tez/conf does not exist > {code} > > > Observed this issue for other components too AFTER 'Ignore and Proceed' the > Tez client error > The error was seen for following components: > Pig client, Hive server, Metastore, Hive client, Spark service, spark client. > See attached file for output > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > cd3fa5c > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > ae66fe0 > > Diff: https://reviews.apache.org/r/41138/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
