-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41442/
-----------------------------------------------------------

Review request for Ambari, Robert Nettleton and Sandor Magyari.


Bugs: AMBARI-14376
    https://issues.apache.org/jira/browse/AMBARI-14376


Repository: ambari


Description
-------

Create a KerberosHelper method to create the headless Kerberos identities and 
keytab files (inline). 

This can be used to create the common identities and keytab files before 
parallel invocations attempt to do so. Due to a race condition, parallel 
invocations of the server-side actions to create principals and keytab files 
may lead to invalid keytab files being distributed to some host because the 
password contained in them were clobbered. 

By calling this new method before calls to install and start services the 
potential of the race condition will be avoided. 

```
  boolean ensureHeadlessIdentities(Cluster cluster, Map<String, Map<String, 
String>> existingConfigurations, Set<String> services)
      throws KerberosInvalidConfigurationException, AmbariException;
```


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 2ad6cfc 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 92e8f46 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 c7123a4 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 f5282af 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 cf6bc93 

Diff: https://reviews.apache.org/r/41442/diff/


Testing
-------

# Local test results: 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 58:26.835s
[INFO] Finished at: Tue Dec 15 22:37:26 EST 2015
[INFO] Final Memory: 67M/1285M
[INFO] ------------------------------------------------------------------------

# Jenkins test results: PENDING


Thanks,

Robert Levas

Reply via email to