----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41227/#review110887 -----------------------------------------------------------
Ship it! Ship It! - Jaimin Jetly On Dec. 16, 2015, 7:04 a.m., Matt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41227/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 7:04 a.m.) > > > Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alejandro > Fernandez, bhuvnesh chaudhary, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, > Oleksandr Diachenko, and Richard Zang. > > > Bugs: AMBARI-14315 > https://issues.apache.org/jira/browse/AMBARI-14315 > > > Repository: ambari > > > Description > ------- > > Any property with index 0 in site_properties.js ends up at the bottom of the > config section. Property with index 0 should ideally be at the top. > > Reason why this happens: > https://github.com/apache/ambari/blob/trunk/ambari-web/app/mappers/configs/stack_config_properties_mapper.js#L172 > > config.index = uiConfigProperty.index || Infinity; > When uiConfigProperty.index = 0, config.index = Infinity > > > Diffs > ----- > > ambari-web/app/mappers/configs/stack_config_properties_mapper.js 3cc08a4 > > Diff: https://reviews.apache.org/r/41227/diff/ > > > Testing > ------- > > Manually tested. > Parameter with index 0 appears above parameter with index 1. > > > Thanks, > > Matt > >
