> On Dec. 16, 2015, 5:35 p.m., Robert Levas wrote: > > Ship It! > > Vishal Ghugare wrote: > Thanks Robert for the review. I would appreciate if you can help me > commit the code (I am not a commiter).
Sure... I am running unit tests now. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41469/#review110774 ----------------------------------------------------------- On Dec. 16, 2015, 5:20 p.m., Vishal Ghugare wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41469/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 5:20 p.m.) > > > Review request for Ambari and Robert Levas. > > > Bugs: AMBARI-12686 > https://issues.apache.org/jira/browse/AMBARI-12686 > > > Repository: ambari > > > Description > ------- > > In a RM HA setup, YARN could work ever there is only 1 RM available, I would > expect the service status for YARN is yellow or green(with alerts) from UI > instead of red. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 7a3d330 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > f067f49 > > Diff: https://reviews.apache.org/r/41469/diff/ > > > Testing > ------- > > 6 unit tests have been added to test YARN service status. These tests > basically cover the service status when: > -all yarn services Installed (HA) > -all yarn services Started (HA) > -one RM Started and the other one Installed (HA) > -both RMs are Installed (HA) > -Has only one RM and it is Started (Non-HA) > -Has only one RM and it is Installed (Non-HA) > > > Thanks, > > Vishal Ghugare > >
