[
https://issues.apache.org/jira/browse/AMBARI-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062085#comment-15062085
]
Hadoop QA commented on AMBARI-14371:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12777495/AMBARI-14371.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The test build failed in ambari-web
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/4628//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/4628//console
This message is automatically generated.
> No eventual config changes should not recommend extra config changes
> --------------------------------------------------------------------
>
> Key: AMBARI-14371
> URL: https://issues.apache.org/jira/browse/AMBARI-14371
> Project: Ambari
> Issue Type: Bug
> Components: ambari-web
> Affects Versions: 2.2.0
> Reporter: Andrii Babiichuk
> Assignee: Andrii Babiichuk
> Fix For: 2.4.0
>
> Attachments: AMBARI-14371.patch
>
>
> This ticket proposes that if user has not made any eventual config change
> (for example "Enabled Ranger plugin for HBase" and then disabled it again)
> then ambari should not show any extra config changes.
> For this we need to keep track of explicit config changes that are being made
> by the user. If a config change at any time negates all the user config
> changes done before then UI should send configs in the data posted in
> recommendation API as received from stack (on installer/ASW wizard) or the
> last service config version (post-install).
> Please find below examples:
> First example:
> On Installer/ASW, When user lands on "Customize Services" page, ui posts data
> to recommendation API with all config values as received from stack endpoint
> After that, If user changes "Ranger plugin for HBase" to ON, ui send
> recommendation API with all config values as received from stack endpoint +
> overriden value of some config received from response of API executed in
> step-1
> User Changes "Ranger plugin for HBase" to OFF, ui should post data to
> recommendation API with all config values as received from stack endpoint (as
> done in step1). The reason being the all users previously explicitly made
> changes have been negated at this point
> Second Example:
> On Installer/ASW, When user lands on "Customize Services" page, ui posts data
> to recommendation API with all config values as received from stack endpoint
> After that, If user changes "Ranger plugin for HBase" to ON and changes some
> other property "xyz" to "v1", ui send recommendation API with all config
> values as currently set in UI (received from stack endpoint + overriden value
> of some config received from response of API executed in step-1)
> Changes "Ranger plugin for HBase" to OFF, ui should post data to
> recommendation API with all config values as set currently on UI (same
> behavior as ui displays today).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
