> On Dec. 18, 2015, 4:28 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java, > > line 145 > > <https://reviews.apache.org/r/41526/diff/2/?file=1170920#file1170920line145> > > > > This is pretty useful function to parse alerts source json and change > > some values. > > Could we move those to general functions into abstractCatalog. > > > > I think we will need that a lot in future. > > > > Let's say we can create 2 functions one returns json as map, other > > saves the json. Or anything else general you think is better. > > Andrew Onischuk wrote: > The goal is to make future upgrade changes to alerts source look as small > as possible. > > Vitalyi Brodetskyi wrote: > We have some usefull functions in entity as of now, so i think it will be > better to add some additional there. Even if we will decide to add some > functions in AbstractUpgradeCatalog, i think it should be implemented as a > feature in separate jira, with Unit Tests and etc.
Can you create a jira than? - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41526/#review111196 ----------------------------------------------------------- On Dec. 18, 2015, 4:41 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41526/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 4:41 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and > Sumit Mohanty. > > > Bugs: AMBARI-14424 > https://issues.apache.org/jira/browse/AMBARI-14424 > > > Repository: ambari > > > Description > ------- > > For Hive metastore and server alerts > 1) Change default timeout to 60 seconds > 2) Make this a configurable script param, so people can pass this in > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py > 55fd6bd > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java > 5e22f71 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json > 55e3f78 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py > c7a9102 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py > a04c2a6 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/41526/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
