> On Dec. 18, 2015, 7:30 p.m., jun aoki wrote: > > ambari-web/app/controllers/main/service/add_controller.js, line 350 > > <https://reviews.apache.org/r/41551/diff/1/?file=1170875#file1170875line350> > > > > Lack of my knowledge but wanted ask, is this function overriding slave > > recommendation from stack_advisor?
yes, in Add Service getSlaveComponentHosts set the components instead of stack_advisor. - Andrii ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41551/#review111236 ----------------------------------------------------------- On Dec. 18, 2015, 1:02 p.m., Andrii Tkach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41551/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 1:02 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Jaimin Jetly. > > > Bugs: AMBARI-14427 > https://issues.apache.org/jira/browse/AMBARI-14427 > > > Repository: ambari > > > Description > ------- > > Add Service wizard: Ambari web should select slaves as per the recommendation > given by stack advisor > > > Diffs > ----- > > ambari-web/app/controllers/main/service/add_controller.js 1f8133d > ambari-web/app/controllers/wizard/step6_controller.js 04930f4 > > Diff: https://reviews.apache.org/r/41551/diff/ > > > Testing > ------- > > 11763 tests complete (15 seconds) > 132 tests pending > > > Thanks, > > Andrii Tkach > >
