> On Dec. 16, 2015, 6:24 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server/serverConfiguration.py, line
> > 1315
> > <https://reviews.apache.org/r/41402/diff/1/?file=1164767#file1164767line1315>
> >
> > Shouldn't this check of property is in properties dictionary first?
> > Right now it is checking if the value is None or 0
Properties will return empty string if property is absent. So we are checking
if property is empty or absent
def get_property(self, key):
return self._props.get(key, '')
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41402/#review110711
-----------------------------------------------------------
On Dec. 16, 2015, 11:01 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41402/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 11:01 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and
> Sid Wagle.
>
>
> Bugs: AMBARI-14385
> https://issues.apache.org/jira/browse/AMBARI-14385
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Robust Handling of Ambari properites and DB state.
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
> c6f90c0
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
> c4a4e4c
> ambari-server/src/main/python/ambari-server.py 41fdfb6
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 223c608
> ambari-server/src/main/python/ambari_server_main.py e9bdec3
>
> Diff: https://reviews.apache.org/r/41402/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
