----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41738/#review111992 -----------------------------------------------------------
ambari-web/app/mixins/common/configs/config_recommendation_parser.js (line 22) <https://reviews.apache.org/r/41738/#comment172305> Please use indentation with 2 spaces. ambari-web/app/mixins/common/configs/config_recommendations.js (line 97) <https://reviews.apache.org/r/41738/#comment172306> Is this meant to always be false? - Apache Ambari On Dec. 28, 2015, 11:03 a.m., Andriy Babiichuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41738/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 11:03 a.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-14501 > https://issues.apache.org/jira/browse/AMBARI-14501 > > > Repository: ambari > > > Description > ------- > > Simplify logic to make it reusable (ex. for Kerberos) and performance > improvement. > Separete logic for original configs and overrides, move it do diff mixins > Separate logic for recommendatins popup manipulations. > Move specific logic like override initial value or ignore recommendations (ex > Add service installed services) to appropriate controllers. > Besides logical refactor this cahges decrease recommendation flow process for > 0.2-0.4 secs for full stack > > > Diffs > ----- > > ambari-web/app/controllers/main/service/info/configs.js > 1eef9a1cebfbebb54dc48a97bf7348c1fe37aea5 > ambari-web/app/controllers/wizard/step7_controller.js > 272623603bbe7d7de8666b1b70e5e0d8ad3c99e5 > ambari-web/app/mixins.js 90fbaa29c388cbb863ca9e453c4b1e69578549a8 > ambari-web/app/mixins/common/configs/config_recommendation_parser.js > PRE-CREATION > ambari-web/app/mixins/common/configs/config_recommendations.js PRE-CREATION > > ambari-web/app/mixins/common/configs/config_with_override_recommendation_parser.js > PRE-CREATION > ambari-web/app/mixins/common/configs/configs_saver.js > 09cfd6f8b56bbc4a4eebf82156503dceb77dd140 > ambari-web/app/mixins/common/configs/enhanced_configs.js > 7efcf55ae040184faecbaf8e6d12ba80d586764b > ambari-web/app/mixins/common/serverValidator.js > 79387290c4c502ed56b6cd815f907572681c8f97 > ambari-web/app/models/configs/objects/service_config.js > 2bc151b93bbaa26b13a368816427a87ab2b6bdf2 > ambari-web/app/models/configs/objects/service_config_property.js > 3a4ca3d5813dc97982d15516564a843e284b72d3 > ambari-web/app/routes/add_service_routes.js > 35b06ab2684021ba49a6f12817a603693aa9304e > ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs > ca6259279f5d284b04d1529b5e81163d92d5185a > ambari-web/app/utils/config.js f4c8034d397862a0bae9143bce05895e3ffaf224 > ambari-web/app/views/common/controls_view.js > a88be769a6821ec61d87a92df564fe4151bf4acb > ambari-web/app/views/common/modal_popups/select_groups_popup.js > 264d7b1759f2f7091accd81ed1d86fa7eb169be2 > ambari-web/test/controllers/main/service/info/config_test.js > b6abb8e1c1a969a2e850cb283ce0568d68a30f2b > ambari-web/test/mixins/common/configs/enhanced_configs_test.js > 1b7115c1d8102047efd329b666fdb7e2c5d8f1bb > ambari-web/test/views/common/configs/widgets/config_widget_view_test.js > e7f979b00f621c4925b04be7d3ee3412f43f5f15 > > Diff: https://reviews.apache.org/r/41738/diff/ > > > Testing > ------- > > 22228 tests complete (13 seconds) > 163 tests pending > > > Thanks, > > Andriy Babiichuk > >
