-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41621/#review112032
-----------------------------------------------------------

Ship it!


Ship It!

- Alexandr Antonenko


On Dec. 22, 2015, 1:08 a.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41621/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 1:08 a.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-14443
>     https://issues.apache.org/jira/browse/AMBARI-14443
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In the Move Master wizard, during the process of moving the NameNode to 
> another host, when the manual commands are displayed, the text scrolls out of 
> the frame when the message is long.
> 
> The white-space property for .code-snippet css class which is applied to the 
> frame is set to nowrap. 
> 
> Fix is to set this to normal so that the command wraps to the next line. 
> 
> --- a/ambari-web/app/styles/application.less
> +++ b/ambari-web/app/styles/application.less
> @@ -4930,7 +4930,7 @@ i.icon-asterisks {
>    font-family: Courier;
>    font-size: 12px;
>    padding: 4px;
> -  white-space: nowrap;
> +  white-space: normal;
>  }
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/styles/application.less d80278c 
> 
> Diff: https://reviews.apache.org/r/41621/diff/
> 
> 
> Testing
> -------
> 
> Manual testing and verification. Image of manual command after the fix is 
> attached.
> Ran mvn test successfully for ambari-web
> 
> 11734 tests complete (19 seconds)
> 137 tests pending
> 
> No tests were added/updated since the change was in the css class property.
> 
> 
> File Attachments
> ----------------
> 
> MoveService_NN_withfix.png
>   
> https://reviews.apache.org/media/uploaded/files/2015/12/22/29ea8a4e-0640-4723-8784-0170defdec26__MoveService_NN_withfix.png
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Reply via email to