----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41668/#review112033 -----------------------------------------------------------
Ship it! Ship It! - Alexandr Antonenko On Dec. 23, 2015, 6:27 a.m., Sangeeta Ravindran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41668/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 6:27 a.m.) > > > Review request for Ambari and Alexandr Antonenko. > > > Bugs: AMBARI-14476 > https://issues.apache.org/jira/browse/AMBARI-14476 > > > Repository: ambari > > > Description > ------- > > If the view display name is long and does not contain spaces, for example: > Capacity_Scheduler_View_Instance_1, the display name overlaps with the > version. > > > Diffs > ----- > > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 602c56c > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html > 05cb1d5 > > Diff: https://reviews.apache.org/r/41668/diff/ > > > Testing > ------- > > Fix involves the following changes: > > 1. Adding a new css class instance-link and adding word-wrap property. > Incidentally, instance-link is being used in > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html > but is not defined in the main.css file or elsewhere. > > 2. Since the first column of the row is empty, changed its class to col-sm-1 > (width 8.33%) instead of col-sm-3 (width 25%). > For the second column which displays the view's display name, changed the > class to col-sm-5 (width 41.66%) instead of col-sm-3 (width 25%). > > Manual test and verification. > > > File Attachments > ---------------- > > Display name with fix > > https://reviews.apache.org/media/uploaded/files/2015/12/23/0dea8f21-33b7-4f65-bb28-2d4bae134b22__long_display_name_with_fix.jpg > > > Thanks, > > Sangeeta Ravindran > >
