----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41741/#review112111 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java (line 204) <https://reviews.apache.org/r/41741/#comment172425> Just a personal preference : if (dbAccessor.tableHasPrimaryKey(HOST_COMPONENT_STATE_TABLE, HOST_COMPONENT_STATE_ID_COLUMN)) { return ; } This will avoid very big if else block. - Ajit Kumar On Dec. 28, 2015, 3:23 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41741/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 3:23 p.m.) > > > Review request for Ambari and Myroslav Papirkovskyy. > > > Bugs: AMBARI-14505 > https://issues.apache.org/jira/browse/AMBARI-14505 > > > Repository: ambari > > > Description > ------- > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java > cafbc35 > > Diff: https://reviews.apache.org/r/41741/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
