----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41835/#review112405 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 39) <https://reviews.apache.org/r/41835/#comment172892> Line 39 is same as line 46. Would be great if we can move this outside the if condition of HAWQ and PXF. ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py (line 168) <https://reviews.apache.org/r/41835/#comment172893> Move this comment inside the function enclosed by """ as recommended in py docs? - Matt On Dec. 31, 2015, 1:47 p.m., Lav Jain wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41835/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2015, 1:47 p.m.) > > > Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Alexandr > Antonenko, bhuvnesh chaudhary, Jaimin Jetly, jun aoki, Jayush Luniya, Lav > Jain, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. > > > Bugs: AMBARI-14301 > https://issues.apache.org/jira/browse/AMBARI-14301 > > > Repository: ambari > > > Description > ------- > > Update stack advisor createComponentLayoutRecommendations to recommend > co-location of HAWQ segment on all hosts where DATANODE is enabled. > > Also, **services-pxf-hdfs.json** was renamed to > **services-hawq-pxf-hdfs.json** > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > e52db2c > ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/common/services-pxf-hdfs.json > 4cd2d4d > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > aa7688b > > Diff: https://reviews.apache.org/r/41835/diff/ > > > Testing > ------- > > Unit test added to test_stack_advisor.py > Also tested manually. > > > Thanks, > > Lav Jain > >
