> On Dec. 30, 2015, 9:29 a.m., bhuvnesh chaudhary wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py, > > line 245 > > <https://reviews.apache.org/r/41795/diff/1/?file=1178449#file1178449line245> > > > > We can extend this condition to handle cases where we have 2 datanodes > > because in that case as well dfs.replication = 3 is not appropriate. > > > > So If 1 DN,dfs.replication=1, If 2 DN, dfs.replication=2. > > Rest as is.
After giving it some thought, I prefer to have dfs.replication to be set as 3, regardless of no. of datanodes. Sumit has a good point. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41795/#review112321 ----------------------------------------------------------- On Dec. 30, 2015, 3:04 a.m., Matt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41795/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2015, 3:04 a.m.) > > > Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh > chaudhary, Dmitro Lisnichenko, jun aoki, Lav Jain, Newton Alex, Oleksandr > Diachenko, Sumit Mohanty, and Srimanth Gunturi. > > > Bugs: AMBARI-14459 > https://issues.apache.org/jira/browse/AMBARI-14459 > > > Repository: ambari > > > Description > ------- > > By default dfs.replication is set to 3. In a single node cluster, advise and > validate dfs.replication = 1 > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 7e2871b > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 6699e94 > > Diff: https://reviews.apache.org/r/41795/diff/ > > > Testing > ------- > > Manually Tested > Unit test updated. > > > Thanks, > > Matt > >
