----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41886/#review112597 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java (line 21) <https://reviews.apache.org/r/41886/#comment173096> Explicit imports. ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java (line 231) <https://reviews.apache.org/r/41886/#comment173098> Documentation. - Jonathan Hurley On Jan. 4, 2016, 11:32 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41886/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 11:32 a.m.) > > > Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi. > > > Bugs: AMBARI-14538 > https://issues.apache.org/jira/browse/AMBARI-14538 > > > Repository: ambari > > > Description > ------- > > Stale alerts should include the host name(s) associated with the alerts. As > these are ambari-server alerts reporting status about alerts that are not run > including the host names in the alert_text may be a valid option. > > The following pattern should be used for this alert: > {code} > The following host(s) have alerts which have not run within their specified > intervals: <hostname>[<alert_label_1> (<stale_time>), <alert_label_2> > (<stale_time>)], <hostname-2> ... > {code} > > For example: > {code} > The following host(s) have alerts which have not run within their specified > intervals: c6401.ambari.apache.org[NodeManager Web UI (12m), NameNode Process > (6m), DataNode Health (2h)], c6402.ambari.apache.org[Flume Agent (2d)] > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java > 206b2ca > > Diff: https://reviews.apache.org/r/41886/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
