----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41768/#review112785 -----------------------------------------------------------
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/utils/SharedObjectsFactory.java (line 182) <https://reviews.apache.org/r/41768/#comment173275> This part of the code can throw ConcurrentModificationException. Though the scenario will be very rare, still it is better to guard it by a lock. - DIPAYAN BHOWMICK On Dec. 29, 2015, 10:01 a.m., Gaurav Nagar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41768/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 10:01 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Srimanth Gunturi, Sid Wagle, and > Yusaku Sako. > > > Bugs: AMBARI-14514 > https://issues.apache.org/jira/browse/AMBARI-14514 > > > Repository: ambari > > > Description > ------- > > Added HiveViewImpl class which removes cached objects from UserLocal and > SharedObjectsFactory > > > Diffs > ----- > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HiveViewImpl.java > PRE-CREATION > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/utils/SharedObjectsFactory.java > bb49400 > contrib/views/hive/src/main/resources/view.xml e04ed4b > > Diff: https://reviews.apache.org/r/41768/diff/ > > > Testing > ------- > > Manual Testing. > > > Thanks, > > Gaurav Nagar > >
