> On Jan. 6, 2016, 7:31 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java, > > lines 357-361 > > <https://reviews.apache.org/r/41973/diff/1/?file=1183964#file1183964line357> > > > > How would `newRangerKmsProps` ever be empty? Did you mean to update > > this outside of the loop? Since it's in a loop, did you mean to > > re-initialize this map each time to clear it out?
It will never be empty. In latest patch, removed isEmpty check. > On Jan. 6, 2016, 7:31 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, > > lines 425-427 > > <https://reviews.apache.org/r/41973/diff/1/?file=1183970#file1183970line425> > > > > This doesn't seem to do anything different than the else below it In latest patch, removed elif logic > On Jan. 6, 2016, 7:31 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, > > lines 460-462 > > <https://reviews.apache.org/r/41973/diff/1/?file=1183970#file1183970line460> > > > > This doesn't seem to do anything different than the else below it In latest patch, removed elif logic > On Jan. 6, 2016, 7:31 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, > > lines 431-432 > > <https://reviews.apache.org/r/41973/diff/1/?file=1183970#file1183970line431> > > > > No return value, like the other statements above. In latest patch, added return value. > On Jan. 6, 2016, 7:31 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, > > lines 466-467 > > <https://reviews.apache.org/r/41973/diff/1/?file=1183970#file1183970line466> > > > > No return value, like the other statements above. In latest patch, added return value. - Gautam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41973/#review113118 ----------------------------------------------------------- On Jan. 7, 2016, 7:34 a.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41973/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 7:34 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan > Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: AMBARI-14550 > https://issues.apache.org/jira/browse/AMBARI-14550 > > > Repository: ambari > > > Description > ------- > > Patch contains stack level changes to add Smart Config options to manage > Ranger KMS DB config properties. > > Now user will have flexibility to Turn On / Off Setup DB and DB Users flag. > Based on the toggle - user needs to provide credentials. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java > 5cde24b > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/dbks-site.xml > 8291e02 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml > 10c14ac > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml > 6c37b94 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml > d5b0aa7 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-policymgr-ssl.xml > fb4a4e6 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 79353e6 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 2e2e52d > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER_KMS/metainfo.xml > b1a5584 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER_KMS/themes/theme_version_1.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 860b40d > ambari-web/app/models/configs/objects/service_config.js 5d827b7 > ambari-web/app/models/stack_service.js 957d7ae > > Diff: https://reviews.apache.org/r/41973/diff/ > > > Testing > ------- > > Performed following test cases : > > 1) Setup Cluster with Ranger KMS using database flavors MYSQL, ORACLE with > Setup DB and DB Users flag as off. > 2) Performed Ambari upgrade from older version using all database flavors to > latest version to check impact of changes in smart configs. > > ---------------------------------------------------------------------- > Ran 271 tests in 6.559s > > OK > ---------------------------------------------------------------------- > Total run:891 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Gautam Borad > >
