> On Jan. 8, 2016, 6:06 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/templates/spark-thrift-fairscheduler.xml.j2, > > line 23 > > <https://reviews.apache.org/r/42051/diff/1/?file=1186627#file1186627line23> > > > > There is no need to make these configurable or editable? > > Jeff Zhang wrote: > It would be better if it could.
Then you can model this as config files with content field (e.g. atlas-env.xml). - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42051/#review113417 ----------------------------------------------------------- On Jan. 8, 2016, 1:18 a.m., Jeff Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42051/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 1:18 a.m.) > > > Review request for Ambari and Sumit Mohanty. > > > Bugs: AMBARI-14561 > https://issues.apache.org/jira/browse/AMBARI-14561 > > > Repository: ambari > > > Description > ------- > > This is for HDP stack, in HDP stack, we'd like to do following changes for > spark thrift server > - Remove advanced properties except queue name > - Use yarn-client mode > - Enable Dynamic Resource Allocation > - Enable Fair scheduling policy > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py > 4b38572 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/templates/spark-thrift-fairscheduler.xml.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-hive-site-override.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml > 6c0e393 > > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/quicklinks/quicklinks.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/42051/diff/ > > > Testing > ------- > > This patch doesn't solve the issue completly. The weird thing is that the > configuration in HDP 2.3's spark-thrift-sparkconf.xml will be appended to > HDP-2.4's spark-thrift-sparkconf.xml. And what I want is remove some > configuration in 2.3. And actually I make Spark 1.6 of HDP 2.4 extend Spark > 1.2 in common-services, not sure why it still use spark-thrift-sparkconf.xml > in HDP 2.3 > > > Thanks, > > Jeff Zhang > >
