-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41980/#review113782
-----------------------------------------------------------
-1. This will not work given changes in AMBARI-14430, AMBARI-14474. All
hardcoded versions for packages have now been replaced with ${stack_version}.
So as such this substitution will no longer happen in the script anymore,
unless someone has explicitly hardcoded the version in stack definition.
- <name>hadoop_2_2_*</name>
+ <name>hadoop_${stack_version}</name>
- Jayush Luniya
On Jan. 6, 2016, 3:45 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41980/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 3:45 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-14567
> https://issues.apache.org/jira/browse/AMBARI-14567
>
>
> Repository: ambari
>
>
> Description
> -------
>
> *Important, As I understand:*
>
> Originally pluggable-stack script was designed to do following:
> * replace stack name
> * replace versions in packages and code
>
> *But this script is not configurable.* For example, we can't change just
> stack name and version, package versions will be also changed.
> We need to refactor pluggable-stack script and define more config options to
> allow to configure which replacements we will perform.
>
> STR:
> 1) Clone ambari sources from repository
> 2) make
> {code}
> python
> /home/eugene/dev/ambari/ambari-common/src/main/python/pluggable_stack_definition/GenerateStackDefinition.py
> -c ${pluggableStackDefinitionConfig} -r ${resourcesSrcLocation} -o
> ${pluggableStackDefinitionOutput}
> {code}
> where
> {code}
> ${pluggableStackDefinitionConfig} - way to CUSTOM.json
> ${resourcesSrcLocation} = /ambari/ambari-server/src/main/resources
> ${pluggableStackDefinitionOutput} - some directory for output
> {code}
> 3) Put custom_stack_map.json to
> /ambari/ambari-common/src/main/python/pluggable_stack_definition/resources/CUSTOM
> 4) make
> {code}
> mvn versions:set -DnewVersion=2.1.3.0.0
> {code}
> for ambari and ambari-metrics
> 5) make packages
> {code}
> mvn -B clean package rpm:rpm -Dpython.ver="python >= 2.6" -DskipTests -pl
> ambari-agent,ambari-web,ambari-server,ambari-admin,ambari-views,ambari-metrics/ambari-metrics-common
> -Dstack.distribution=CUSTOM
> -DpluggableStackDefinitionConfig=/ambari/ambari-common/src/main/python/pluggable_stack_definition/configs/CUSTOM.json
> {code}
> 6) install and setup ambari from rpms
> 7) Try to deploy ambari
>
> *Actual results:*
> Can not deploy ambari with custom stack correctly, with out specific package
> files (3_3_*) for services.
> {code}
> resource_management.core.exceptions.Fail: Execution of '/usr/bin/yum -d 0 -e
> 0 -y install 'accumulo_3_3_*'' returned 1. Error: Nothing to do
> {code}
>
>
> Diffs
> -----
>
>
> ambari-common/src/main/python/pluggable_stack_definition/GenerateStackDefinition.py
> d068d1f
> ambari-common/src/main/python/pluggable_stack_definition/configs/PHD.json
> 521489f
>
> Diff: https://reviews.apache.org/r/41980/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
