> On Jan. 12, 2016, 11:16 a.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py, > > line 298 > > <https://reviews.apache.org/r/42021/diff/2/?file=1190078#file1190078line298> > > > > This is conter intuitive to ignore directories, I don't the person > > which uses this resource later would be happy with this behaviour.
edit: "I don't think the person, who will use hdfsResource later will know about this type of behaviour." - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42021/#review113971 ----------------------------------------------------------- On Jan. 12, 2016, 8:26 a.m., yao lei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42021/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 8:26 a.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-14536 > https://issues.apache.org/jira/browse/AMBARI-14536 > > > Repository: ambari > > > Description > ------- > > In some cases,we need to copy local matching wildcard files to hdfs. > eg. we'd like to copy /usr/lib/spark*.jar to hdfs by following codes in > Python: > params.HdfsResource(hdfs_path, > type="file", > action="create_on_execute", > source="/usr/lib/spark*.jar", > group=params.user_group, > owner=params.pdm_user, > mode=0755 > ) > params.HdfsResource(None, action="execute") > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py > 731bce7 > > Diff: https://reviews.apache.org/r/42021/diff/ > > > Testing > ------- > > Manually Tested. > > > Thanks, > > yao lei > >
