> On Jan. 12, 2016, 8:05 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2152 > > <https://reviews.apache.org/r/42175/diff/1/?file=1192884#file1192884line2152> > > > > Minor issue: > > > > I would recommend adding the new PropertyUpdater registrations to the > > "singleHostTopologyUpdaters" map, rather than the multi-host map. > > > > Either should work fine, but it probably makes more sense to keep the > > single-host properties in the single-host map, for tracking and maintenance > > purposes. > > bhuvnesh chaudhary wrote: > Thanks Robert for the suggestion. Will do that and update the pach.
Used singleHostTopologyUpdaters as suggested. - bhuvnesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42175/#review114057 ----------------------------------------------------------- On Jan. 13, 2016, 12:49 a.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42175/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 12:49 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, > Jayush Luniya, Oleksandr Diachenko, Robert Nettleton, Richard Zang, and Sumit > Mohanty. > > > Bugs: AMBARI-14621 > https://issues.apache.org/jira/browse/AMBARI-14621 > > > Repository: ambari > > > Description > ------- > > Blueprint deploy should update the value localhost for HAWQMASTER, > HAWQSTANDBY with the name of their respective component hostname. It should > also update the value of hawq_dfs_url to NAMENODE HOST. > The logic to replace the hostname is currently only on the Web UI due to > which during deploy, hawq_master_address_host, hawq_standby_address_host and > hawq_dfs_url are set to localhost and hawq start fails. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > cded321 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py > 95c4eba > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 3c643be > > Diff: https://reviews.apache.org/r/42175/diff/ > > > Testing > ------- > > yes. test case added. > > > Thanks, > > bhuvnesh chaudhary > >
