----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42308/#review114498 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java (line 552) <https://reviews.apache.org/r/42308/#comment175351> Wondering about heap and potential unicode conversion issues here. ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java <https://reviews.apache.org/r/42308/#comment175352> Are all components associated with a repo now? ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql <https://reviews.apache.org/r/42308/#comment175350> Not that it needs to be done in this commit, but you should make a Jira to track this change in an upgrade catalog. - Jonathan Hurley On Jan. 14, 2016, 11:45 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42308/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 11:45 a.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-14650 > https://issues.apache.org/jira/browse/AMBARI-14650 > > > Repository: ambari > > > Description > ------- > > Added columns to repo_version for repos that are created via Version XML file. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 061a373 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > 5f14793 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java > e12e118 > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > def33f0 > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/AvailableService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/AvailableVersion.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/ManifestService.java > 0097110 > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java > 92ab6b3 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java > eff063b > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 72413ce > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3c23737 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql bcaee11 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6ebc3a9 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > ee165bf > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql f7be93b > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql baf120f > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > 17e983e > ambari-server/src/test/resources/version_definition_resource_provider.xml > PRE-CREATION > ambari-server/src/test/resources/version_definition_test.xml fadfeea > > Diff: https://reviews.apache.org/r/42308/diff/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
