> On Січ. 14, 2016, 4:02 після полудня, Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > line 2274 > > <https://reviews.apache.org/r/42306/diff/2/?file=1196918#file1196918line2274> > > > > I'm almost certain that the "INITIAL_INSTALL" phase is only set when a > > Blueprints deployment is used. > > > > @smohanty can comment on this further. > > > > Adding the new "deployType" of "BLUEPRINT" is fine, but may not be > > necessary, considering my comment above.
I have checked...we are really using INITIAL_INSTALL only for blueprint install > On Січ. 14, 2016, 4:02 після полудня, Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java, > > line 369 > > <https://reviews.apache.org/r/42306/diff/2/?file=1196919#file1196919line369> > > > > Again, I'm not sure this separate "deployType" is really needed, since > > the "INITIAL_INSTALL" phase is set. > > > > That being said, it wouldn't necessarily be a bad idea to have this > > deployType set explicitly. > > > > I'm ok with this either way, just wanted to register this comment for > > possible further review if necessary. I have checked...we are really using INITIAL_INSTALL only for blueprint install > On Січ. 14, 2016, 4:02 після полудня, Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java, > > line 125 > > <https://reviews.apache.org/r/42306/diff/2/?file=1196920#file1196920line125> > > > > The Stack class can be used to determine if a property is a customized > > value, or is just a stack default. > > > > Please see: > > > > > > org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor#doFilterStackDefaults > > > > for an example of how to use the Stack class to determine if the > > current config property is equal to it's stack default. > > > > I'm not sure there's any way to determine the difference between the > > stack default and a user copying the stack default. I don't think we should fix users issues. If user set property in blueprint, then we are just using it. - Vitalyi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42306/#review114488 ----------------------------------------------------------- On Січ. 14, 2016, 6:48 після полудня, Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42306/ > ----------------------------------------------------------- > > (Updated Січ. 14, 2016, 6:48 після полудня) > > > Review request for Ambari, Robert Levas and Robert Nettleton. > > > Bugs: AMBARI-14668 > https://issues.apache.org/jira/browse/AMBARI-14668 > > > Repository: ambari > > > Description > ------- > > 1) Deploy cluster with HDFS,YARN,Oozie, Storm,Zookeeper. > 2) Enable security. > 3) Customize some properties: hadoop.proxyuser.yarn.hosts, > hadoop.proxyuser.HTTP.groups, oozie.authentication.type, > yarn.timeline-service.http-authentication.type. > 4) Export blueprint config. Check that customized properties are correct in > exported config. > 5) Deploy kerberized cluster via blueprints. > 6) Check that after deploy customized properties are the same as they were > set during customization. > Result: customized properties were reverted. Looks like during BP deploy, we > are just updating all kerberos properties with values from kerberos.json from > related service > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 739cd43 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > c885ca7 > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java > 9390b3a > > Diff: https://reviews.apache.org/r/42306/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
