-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42317/
-----------------------------------------------------------

(Updated Jan. 15, 2016, 5:52 p.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
-------

* Fixed the maven integration
* Made some style changes to conform to a newer version of pylint


Bugs: AMBARI-14673
    https://issues.apache.org/jira/browse/AMBARI-14673


Repository: ambari


Description
-------

This replaces the existing Python client wholesale with the client I developed 
for my team at Rackspace: 
https://github.com/jimbobhickville/python-ambariclient  It has been tested and 
battle-hardened, and supports almost the entire Ambari API.


Diffs (updated)
-----

  ambari-client/python-client/pom.xml b8cfb94 
  ambari-client/python-client/src/examples/create.py c5f2658 
  ambari-client/python-client/src/examples/delete.py 3debc4c 
  ambari-client/python-client/src/examples/example.py 6702eda 
  ambari-client/python-client/src/examples/main.py 04db4c0 
  ambari-client/python-client/src/examples/trial.py 5a7a7af 
  ambari-client/python-client/src/main/python/.gitignore PRE-CREATION 
  ambari-client/python-client/src/main/python/MANIFEST.in PRE-CREATION 
  ambari-client/python-client/src/main/python/README.md PRE-CREATION 
  ambari-client/python-client/src/main/python/ambari_client/__init__.py 278df2e 
  ambari-client/python-client/src/main/python/ambari_client/ambari_api.py 
d3832c8 
  ambari-client/python-client/src/main/python/ambari_client/core/__init__.py 
278df2e 
  ambari-client/python-client/src/main/python/ambari_client/core/coreutils.py 
56f10c3 
  ambari-client/python-client/src/main/python/ambari_client/core/errors.py 
eb3644a 
  ambari-client/python-client/src/main/python/ambari_client/core/http_client.py 
7f7e526 
  ambari-client/python-client/src/main/python/ambari_client/core/http_utils.py 
5c0dc2f 
  
ambari-client/python-client/src/main/python/ambari_client/core/rest_resource.py 
9e98178 
  ambari-client/python-client/src/main/python/ambari_client/model/__init__.py 
278df2e 
  ambari-client/python-client/src/main/python/ambari_client/model/base_model.py 
1d4fc15 
  ambari-client/python-client/src/main/python/ambari_client/model/blueprint.py 
21b0b33 
  ambari-client/python-client/src/main/python/ambari_client/model/cluster.py 
7e0b378 
  ambari-client/python-client/src/main/python/ambari_client/model/component.py 
c0323ab 
  
ambari-client/python-client/src/main/python/ambari_client/model/configuration.py
 730ca33 
  ambari-client/python-client/src/main/python/ambari_client/model/host.py 
dd4bcb4 
  ambari-client/python-client/src/main/python/ambari_client/model/paths.py 
17a4633 
  ambari-client/python-client/src/main/python/ambari_client/model/service.py 
acd7528 
  ambari-client/python-client/src/main/python/ambari_client/model/stack.py 
4d63376 
  ambari-client/python-client/src/main/python/ambari_client/model/status.py 
8ef1140 
  ambari-client/python-client/src/main/python/ambari_client/model/utils.py 
65dd153 
  ambari-client/python-client/src/main/python/ambari_client/model/views.py 
561cdbd 
  ambari-client/python-client/src/main/python/ambariclient/__init__.py 
PRE-CREATION 
  ambari-client/python-client/src/main/python/ambariclient/base.py PRE-CREATION 
  ambari-client/python-client/src/main/python/ambariclient/client.py 
PRE-CREATION 
  ambari-client/python-client/src/main/python/ambariclient/events.py 
PRE-CREATION 
  ambari-client/python-client/src/main/python/ambariclient/exceptions.py 
PRE-CREATION 
  ambari-client/python-client/src/main/python/ambariclient/models.py 
PRE-CREATION 
  ambari-client/python-client/src/main/python/ambariclient/shell.py 
PRE-CREATION 
  ambari-client/python-client/src/main/python/ambariclient/utils.py 
PRE-CREATION 
  ambari-client/python-client/src/main/python/bin/ambari-shell PRE-CREATION 
  ambari-client/python-client/src/main/python/pylint.conf PRE-CREATION 
  ambari-client/python-client/src/main/python/pytest.ini PRE-CREATION 
  ambari-client/python-client/src/main/python/requirements.txt PRE-CREATION 
  ambari-client/python-client/src/main/python/setup.py 24942ad 
  ambari-client/python-client/src/main/python/test-requirements.txt 
PRE-CREATION 
  ambari-client/python-client/src/main/python/tests/test_models.py PRE-CREATION 
  ambari-client/python-client/src/main/python/tests/test_utils.py PRE-CREATION 
  ambari-client/python-client/src/main/python/tox.ini PRE-CREATION 
  ambari-client/python-client/src/test/python/TestAmbariClient.py f96d6b0 
  ambari-client/python-client/src/test/python/TestClusterModel.py b501d29 
  ambari-client/python-client/src/test/python/TestComponentModel.py b3f1530 
  ambari-client/python-client/src/test/python/TestHostModel.py 8b3b531 
  ambari-client/python-client/src/test/python/TestServiceModel.py 6933701 
  ambari-client/python-client/src/test/python/TestStatusModel.py 107bd84 
  
ambari-client/python-client/src/test/python/json/ambariclient_bootstrap_hosts.json
 1e60bd0 
  
ambari-client/python-client/src/test/python/json/ambariclient_get_all_clusters.json
 abbf619 
  
ambari-client/python-client/src/test/python/json/ambariclient_get_all_hosts.json
 2aca5c4 
  
ambari-client/python-client/src/test/python/json/ambariclient_get_components.json
 56bb1b2 
  ambari-client/python-client/src/test/python/json/ambariclient_get_config.json 
38bba47 
  ambari-client/python-client/src/test/python/json/ambariclient_get_host.json 
d710626 
  
ambari-client/python-client/src/test/python/json/clustermodel_error_deleting_host.json
 06d1bc9 
  
ambari-client/python-client/src/test/python/json/clustermodel_get_all_hosts.json
 614f8d4 
  
ambari-client/python-client/src/test/python/json/clustermodel_get_all_services.json
 53bb2da 
  
ambari-client/python-client/src/test/python/json/clustermodel_get_cluster.json 
4c72dea 
  
ambari-client/python-client/src/test/python/json/clustermodel_get_core_site_config.json
 309ba13 
  
ambari-client/python-client/src/test/python/json/clustermodel_get_global_config.json
 bb59fb5 
  
ambari-client/python-client/src/test/python/json/clustermodel_get_hdfs_site_config.json
 9108aa7 
  ambari-client/python-client/src/test/python/json/clustermodel_get_host.json 
b1b09d6 
  
ambari-client/python-client/src/test/python/json/clustermodel_get_mapred_site_config.json
 1080be1 
  
ambari-client/python-client/src/test/python/json/clustermodel_get_service.json 
0c9d5e7 
  
ambari-client/python-client/src/test/python/json/componentmodel_get_metrics.json
 5623d8b 
  ambari-client/python-client/src/test/python/json/get_cluster_service.json 
5b78e05 
  
ambari-client/python-client/src/test/python/json/get_components_from_stack.json 
55a9c09 
  ambari-client/python-client/src/test/python/json/get_host_component.json 
709b94b 
  ambari-client/python-client/src/test/python/json/get_host_components.json 
94a3027 
  ambari-client/python-client/src/test/python/json/get_service_component.json 
3e993cd 
  ambari-client/python-client/src/test/python/json/get_service_components.json 
967bcbd 
  
ambari-client/python-client/src/test/python/json/hostmodel_get_host_component.json
 436cfda 
  
ambari-client/python-client/src/test/python/json/hostmodel_get_host_components.json
 8148d18 
  
ambari-client/python-client/src/test/python/json/servicemodel_get_component.json
 c6cbd08 
  
ambari-client/python-client/src/test/python/json/servicemodel_get_components.json
 b9efe73 
  
ambari-client/python-client/src/test/python/json/status_error_with_message.json 
69ca96d 
  ambari-client/python-client/src/test/python/json/status_ok_with_id.json 
c805e38 
  ambari-client/python-client/src/test/python/unitTests.py eadfade 
  ambari-client/python-client/src/test/python/utils/HttpClientInvoker.py 
dd753b2 
  ambari-shell/ambari-python-shell/conf/unix/ambari-shell b6109fe 
  ambari-shell/ambari-python-shell/conf/unix/ambari-shell.ini 9ac158d 
  ambari-shell/ambari-python-shell/pom.xml 7b48454 
  ambari-shell/ambari-python-shell/src/main/package/deb/control/control 40cd855 
  ambari-shell/ambari-python-shell/src/main/package/deb/control/postinst 
21a01fa 
  ambari-shell/ambari-python-shell/src/main/package/deb/control/postrm 21a01fa 
  ambari-shell/ambari-python-shell/src/main/package/deb/control/posttrm 21a01fa 
  ambari-shell/ambari-python-shell/src/main/package/deb/control/preinst 21a01fa 
  ambari-shell/ambari-python-shell/src/main/package/deb/control/prerm 21a01fa 
  ambari-shell/ambari-python-shell/src/main/python/ambari_shell/__init__.py 
278df2e 
  ambari-shell/ambari-python-shell/src/main/python/ambari_shell/ambari_shell.py 
79af1a6 
  
ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/__init__.py
 278df2e 
  
ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/blueprint.py
 4d65163 
  
ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/connect_cluster.py
 c28d493 
  
ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/create_cluster.py
 307bf24 
  
ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/service.py
 51fd51c 
  
ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/shell_config.py
 2facd02 
  ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/show.py 
584b40a 
  
ambari-shell/ambari-python-shell/src/main/python/ambari_shell/utils/__init__.py 
278df2e 
  
ambari-shell/ambari-python-shell/src/main/python/ambari_shell/utils/displayutils.py
 3c45e7f 
  
ambari-shell/ambari-python-shell/src/main/python/ambari_shell/utils/osutils.py 
8aeaa34 
  
ambari-shell/ambari-python-shell/src/main/python/ambari_shell/utils/pluginutils.py
 fdcb97c 
  ambari-shell/ambari-python-shell/src/main/python/setup.py b67d872 
  ambari-shell/ambari-python-shell/src/packages/tarball/all.xml 0e4f34b 

Diff: https://reviews.apache.org/r/42317/diff/


Testing
-------

Beyond the unit tests, this has been used in production by my team here for 
over a year now.  There might be obscure edge cases, but for the most part it 
relies on the server to do the heavy lifting, like a client should.


Thanks,

Greg Hill

Reply via email to