----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42337/#review115058 -----------------------------------------------------------
Ship it! Minor comments. Fix & Ship ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java (lines 41 - 42) <https://reviews.apache.org/r/42337/#comment175908> If the meaning here is one-at-a-time, then we should use "sequential" or "synchronous" instead of the java-like implication of thread-safety (implying parallel is ok, but safe) ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java (lines 55 - 56) <https://reviews.apache.org/r/42337/#comment175909> We have the convention of null hostnames for tasks being run on Ambari. If Ambari isn't part of the cluster we'll have problems here. ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml (line 797) <https://reviews.apache.org/r/42337/#comment175910> May want to use the word Oozie or Oozie Server in here somewhere so people understand what's happening. (Random text is weird) - Nate Cole On Jan. 18, 2016, 2:48 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42337/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 2:48 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Jayush Luniya, and Nate Cole. > > > Bugs: AMBARI-14678 > https://issues.apache.org/jira/browse/AMBARI-14678 > > > Repository: ambari > > > Description > ------- > > STR: > HDP 2.2 > Multiple Oozie Servers > RU to HDP 2.3 > > The pre-upgrade directive for Oozie has > ``` > <pre-upgrade> > <task xsi:type="execute" hosts="all" summary="Shut down all Oozie servers"> > <script>scripts/oozie_server.py</script> > <function>stop</function> > </task> > > <task xsi:type="execute" hosts="any" summary="Upgrading the database and > creating a new sharelib"> > <script>scripts/oozie_server_upgrade.py</script> > <function>upgrade_oozie_database_and_sharelib</function> > </task> > </pre-upgrade> > ``` > > Notice that the first task runs on all hosts, and the second task runs on > exactly one random host. The problem is that the scheduler runs both tasks in > one stage on the union of these hosts. Therefore, the 2nd task runs on the > wrong set of hosts. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java > aa852bd > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java > b0df83f > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java > 980f88e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapper.java > 69b3f8b > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java > 057c310 > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > 2cf9da9 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml > cbd9c2a > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 816fe13 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml > 5166c4b > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > 8b2f2a3 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 375da12 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml > ea3d6a6 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 34423f9 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml > 50c8584 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml > 876342c > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml > f145de1 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml > a9ee860 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml > b8bd1ee > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 7e61942 > > ambari-server/src/test/resources/stacks/HDP/2.0.7/services/OOZIE/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_bucket_test.xml > 0e6d914 > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > 4f71b4a > > Diff: https://reviews.apache.org/r/42337/diff/ > > > Testing > ------- > > Verified during RU/EU from HDP 2.2 to 2.3 with multiple Oozie Servers. > > Waiting for unit test results. > > > Thanks, > > Alejandro Fernandez > >
