-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42542/
-----------------------------------------------------------

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jayush Luniya, 
Nate Cole, and Swapan Shridhar.


Bugs: AMBARI-14734
    https://issues.apache.org/jira/browse/AMBARI-14734


Repository: ambari


Description
-------

Customer quit on Save Cluster State and finalized the upgrade later without 
running "ambari-server set-current --cluster-name=$CLUSTERNAME 
--version-display-name=$VERSION_NAME".
Next upgrade from 2.3.2 to 2.3.4 deleted configs from desired stack 2.2
STR:
RU/EU HDP 2.2->2.3 (don't Save Cluster State so that desired stack remains on 
2.2)
RU/EU from HDP 2.3.0.0-2.3.4.0 and Downgrade (this will remove the configs for 
the desired stack, which is still 2.2!)
Need stronger prechecks to prevent starting RU/EU if the previous upgrade did 
not have a downgrade path and the "Save Cluster State" step is not COMPLETED.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 80f1c1c 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 d20203c 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
 9ecabc7 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheck.java
 14b8435 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java
 8708ef4 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
 cdb7c61 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
 1099418 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheck.java
 626438f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
 72091a4 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
 d7c27d7 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
 8d578d8 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java
 8e98c99 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java
 44e183d 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheck.java
 cbb8623 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java
 0a866eb 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java
 062c11f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java
 d3672b1 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/YarnRMHighAvailabilityCheck.java
 9f3bd6e 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
 5dbd0b4 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
 6e3c6b2 

Diff: https://reviews.apache.org/r/42542/diff/


Testing
-------

Verifed with RU from HDP 2.2 to 2.3 where I skipped the "Save Cluster State" 
step.
I then installed bits for another version and the PreChecks for RU and EU 
failed as expected.

Waiting for unit test results.

TODO: write a unit test.


Thanks,

Alejandro Fernandez

Reply via email to