-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42652/
-----------------------------------------------------------
Review request for Ambari and Dmytro Sen.
Bugs: AMBARI-14773
https://issues.apache.org/jira/browse/AMBARI-14773
Repository: ambari
Description
-------
I installed cluster with 3 hosts and 4 services and on all services, except
HDFS (YARN, ZK, MR2) I get error on recommendation request for configs. You
are able to see it if you open browser console and open service configs page.
Request returns:
{
"status" : 500,
"message" : "Stack Advisor reported an error: TypeError: 'NoneType'
object is unsubscriptable\nStdOut file:
/var/run/ambari-server/stack-recommendations/34/stackadvisor.out\n\nStdErr
file: /var/run/ambari-server/stack-recommendations/34/stackadvisor.err"
}
In stackadvisor.err file:
Traceback (most recent call last):
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line
158, in <module>
main(sys.argv)
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line
109, in main
result = stackAdvisor.recommendConfigurations(services, hosts)
File
"/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line
569, in recommendConfigurations
calculation(configurations, clusterSummary, services, hosts)
File
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.3/services/stack_advisor.py",
line 359, in recommendHDFSConfigurations
super(HDP23StackAdvisor,
self).recommendHDFSConfigurations(configurations, clusterData, services, hosts)
File
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.2/services/stack_advisor.py",
line 104, in recommendHDFSConfigurations
super(HDP22StackAdvisor,
self).recommendHDFSConfigurations(configurations, clusterData, services, hosts)
File
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
line 253, in recommendHDFSConfigurations
dataDirs = hdfsSiteProperties['dfs.datanode.data.dir'].split(",")
TypeError: 'NoneType' object is unsubscriptable
We are not sending dfs.datanode.data.dir if it is not HDFS service.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
da2fc47
Diff: https://reviews.apache.org/r/42652/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
