> On Jan. 25, 2016, 1:57 p.m., jun aoki wrote: > > ambari-web/app/views/main/service/item.js, line 209 > > <https://reviews.apache.org/r/42675/diff/1/?file=1218666#file1218666line209> > > > > Matt, it seems to me that it is better to keep the semicolon, since the > > block(from line 201 to 209) is a single statement inside of the if > > statement. > > Could you confirm?
Yes, better to keep the semi-colon. Putting it back. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42675/#review116183 ----------------------------------------------------------- On Jan. 22, 2016, 3:56 p.m., Matt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42675/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 3:56 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko. > > > Bugs: AMBARI-14781 > https://issues.apache.org/jira/browse/AMBARI-14781 > > > Repository: ambari > > > Description > ------- > > Delete additional code which is not required for the custom command HAWQ > CLUSTER IMMEDIATE STOP > > > Diffs > ----- > > ambari-web/app/controllers/main/service/item.js 14552a1 > ambari-web/app/messages.js 34107f6 > ambari-web/app/utils/ajax/ajax.js 4762d34 > ambari-web/app/views/main/service/item.js 659a0a5 > > Diff: https://reviews.apache.org/r/42675/diff/ > > > Testing > ------- > > Manually Tested > > Unit tests passed: > > [INFO] > [INFO] > ------------------------------------------------------------------------ > [INFO] Building Ambari Web 2.0.0.0-SNAPSHOT > [INFO] > ------------------------------------------------------------------------ > [INFO] > > 23090 tests complete (18 seconds) > 164 tests pending > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:12 min > [INFO] Finished at: 2016-01-22T15:36:11-08:00 > [INFO] Final Memory: 12M/311M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Matt > >
