----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42818/#review116448 -----------------------------------------------------------
Fix it, then Ship it! ambari-admin/src/main/resources/ui/admin-web/app/assets/data/version/version.json (line 19) <https://reviews.apache.org/r/42818/#comment177465> This will be one level higher, a sibling to stack_version ambari-admin/src/main/resources/ui/admin-web/app/assets/data/version/version.json (line 28) <https://reviews.apache.org/r/42818/#comment177466> There is an additional field here that was added: display_name, so you won't have to do an additional API call for display purposes. ambari-admin/src/main/resources/ui/admin-web/app/assets/data/version/version.json (lines 40 - 42) <https://reviews.apache.org/r/42818/#comment177467> Right now, API returns an empty list for components when all components are implied. Not committed to that though :) - Nate Cole On Jan. 26, 2016, 2:45 p.m., Xi Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42818/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 2:45 p.m.) > > > Review request for Ambari, Nate Cole and Yusaku Sako. > > > Bugs: AMBARI-14795 > https://issues.apache.org/jira/browse/AMBARI-14795 > > > Repository: ambari > > > Description > ------- > > This one belongs to UI work of Patch Upgrade ( Provide ability to apply > single patches on top of RU release), and is the first part to implement" > Manage Ambari > Register Version" page. > Should generate a new "Register Version" page, and add the ability to load > new version definition file through two options: > 1. Browse local files and then Upload file, > 2. Enter the Url then click on "Read Version File" button, > After either option, the Version File (a .xml file) should be POST to server, > then loaded (GET call) to the page content. > > Be sure to load the mock data, will integrate API later. > > > Diffs > ----- > > > ambari-admin/src/main/resources/ui/admin-web/app/assets/data/version/version.json > 7c604f1 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > a817d88 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > 04485c6 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > ffed3cc > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 895a28f > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > 9b7e032 > > Diff: https://reviews.apache.org/r/42818/diff/ > > > Testing > ------- > > > Thanks, > > Xi Wang > >
