> On Січ. 28, 2016, 4:12 після полудня, Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java,
> >  line 104
> > <https://reviews.apache.org/r/42913/diff/1/?file=1225080#file1225080line104>
> >
> >     Doesn't this already happen in UpgradeCatalog210? Why perform this here?

We perform this here for people who upgraded to 2.2.1 but didn't fix this 
issue. Anyway this code will not breack anything.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42913/#review116781
-----------------------------------------------------------


On Січ. 28, 2016, 4:02 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42913/
> -----------------------------------------------------------
> 
> (Updated Січ. 28, 2016, 4:02 після полудня)
> 
> 
> Review request for Ambari, Dmytro Sen and Robert Levas.
> 
> 
> Bugs: AMBARI-14831
>     https://issues.apache.org/jira/browse/AMBARI-14831
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The problem turns out to be that ambari-server upgrade from 2.0.1 to 2.2.0 
> sets the value of config as (code):
> storm.zookeeper.superACL: "sasl:{{storm_base_jaas_principal}}",
> However STORM scripts expect the config value to be storm_bare_jaas_principal 
> (code). Because of this, the value comes out as empty. (screenshot attached)
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
>  7940e02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  bcbbf41 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
>  f33a31d 
> 
> Diff: https://reviews.apache.org/r/42913/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to