-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43000/
-----------------------------------------------------------

Review request for Ambari and Alexandr Antonenko.


Bugs: ambari-14525
    https://issues.apache.org/jira/browse/ambari-14525


Repository: ambari


Description
-------

If the cluster name is long (25+ characters), it extends beyond the frame in 
the Ambari Admin view and spills into the adjacent frame.

There also seem similar issues in the alerts and confirmation modal dialog 
displayed.


Diffs
-----

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/NavbarCtrl.js
 319a8f2 
  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css f54d87c 
  ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 
17f8f0b 

Diff: https://reviews.apache.org/r/43000/diff/


Testing
-------

Fix involves appending "..." once the length of the cluster name exceeds 20 
characters and adding a tooltip so that the entire name can be viewed if 
desired.

There are also some css changes to prevent longer names to be displayed beyond 
the width of modal dialogs and Ambari alerts by using word-wrap:break-word;

Did manual testing.


File Attachments
----------------

ConfimClusterDlg
  
https://reviews.apache.org/media/uploaded/files/2016/01/30/f9d40846-cfe6-41e5-b0e4-7f7a0e667bbe__ConfirmClusterRenameModalDialog.jpg
ClusterNameAlert
  
https://reviews.apache.org/media/uploaded/files/2016/01/30/404eccc0-6f8c-4d04-ae60-b5e2a58433f0__ClusterRenameAlert_withfix.jpg
LongerClusterNameAdminView
  
https://reviews.apache.org/media/uploaded/files/2016/01/30/eb78f56b-0bc9-47d8-b1a6-b2168627961f__LongClusterNameAdminView_withfix.jpg


Thanks,

Sangeeta Ravindran

Reply via email to