----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43040/#review117210 -----------------------------------------------------------
Fix it, then Ship it! Just a change to use Execute and double-check that you don't need to add any environment variables or paths to the invocation of psql. ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py (line 81) <https://reviews.apache.org/r/43040/#comment178334> Ambari typically uses the `Execute` resource for calls like this. It allows us to better track logging of execution of the command and some built-in bonuses like timeouts. Here's an example: Execute(kinitcmd, user=smokeuser, path=["/bin/", "/usr/bin/", "/usr/lib/hive/bin/", "/usr/sbin/"], timeout=10) Also, do you need to set any paths on this? Looks like you'll need psql on the path at the very least. - Jonathan Hurley On Feb. 1, 2016, 3:48 a.m., Matt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43040/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 3:48 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Jaimin Jetly, > Jonathan Hurley, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-14855 > https://issues.apache.org/jira/browse/AMBARI-14855 > > > Repository: ambari > > > Description > ------- > > HAWQSTANDBY can go out of sync with HAWQMASTER. Show an alert when > HAWQSTANDBY is not in sync with HAWQMASTER. > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/43040/diff/ > > > Testing > ------- > > Manually Tested. > Added an additional unit test. > > All unit tests passed. > > > Thanks, > > Matt > >
