----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42976/#review117264 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AdminSettingResourceProvider.java (line 58) <https://reviews.apache.org/r/42976/#comment178413> protected static final String SETTINGS="Settings"; "Settings" is used multiple times. Using a constant helps. - Nahappan Somasundaram On Feb. 1, 2016, 10:20 a.m., Ajit Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42976/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 10:20 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Jayush Luniya, and Nahappan > Somasundaram. > > > Bugs: AMBARI-14869 > https://issues.apache.org/jira/browse/AMBARI-14869 > > > Repository: ambari > > > Description > ------- > > Currently API endpoint is /admin-settings. Change it to /settings and all > modelling accordingly. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > 070a505ff586162f4822348daab6365237738aae > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AdminSettingService.java > 2c5b77d274d620658f8bd2b765d353d8262cff16 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AdminSettingResourceProvider.java > e8d5b5ed7f63b362c9a662b1fc8119d6a3169c8e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java > ab76458d4c9887a4417737e4c6e238139b8eacde > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > 9d6af76fa799c823d03585cc0e32a6e29b082eee > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AdminSettingDAO.java > 30e032f10a4feae57ba82a15119abd5ea76ba52c > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AdminSettingEntity.java > 9edc7b56aa6755d935bfba89c54cd0dc800ff4c7 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java > 1935d830358872e11b7c1e8be8695c17480be4c8 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > 9982c2af07dfefb0116a85886fa37ccffdc697fe > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql > f05ebd2107c29ca663204ea18f230731e66be993 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql > 96ef3fab6dffb7cfbf93f12da6c38c6d5630116b > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql > 8bd9d03277c07eca2176061fc1a2ce873d8ecc1c > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 54999cb4a636dc4f2b933ff7c41bd7f53984db24 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql > ce058e21e528f14ba1834d408a52a1ede38eba25 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql > 66ea51236a53629ec9da7b85d8b84218d7d577de > ambari-server/src/main/resources/META-INF/persistence.xml > 280b9b6642e813c104c2ececd59398076166e006 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AdminSettingServiceTest.java > d84c97d8775391e5222cb049e5da2ed03a5f97c4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AdminSettingResourceProviderTest.java > e95449c064ae0742316516707977d722f6efb805 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AdminSettingDAOTest.java > 82589740edef49894dd880026f6a04853404a09b > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/AdminSettingEntityTest.java > a7cba2329c9fc80c3b26ea155172e1ac9329fde7 > > Diff: https://reviews.apache.org/r/42976/diff/ > > > Testing > ------- > > Tested APIs manually. Test cases running fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Server ..................................... SUCCESS > [1:03:27.337s] > [INFO] Ambari Functional Tests ........................... SUCCESS [2:00.883s] > [INFO] Ambari Agent ...................................... SUCCESS [16.225s] > [INFO] Ambari Client ..................................... SUCCESS [0.043s] > [INFO] Ambari Python Client .............................. SUCCESS [2.280s] > [INFO] Ambari Groovy Client .............................. SUCCESS [11.465s] > [INFO] Ambari Shell ...................................... SUCCESS [0.043s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.651s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [9.313s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:06:08.886s > [INFO] Finished at: Fri Jan 29 16:46:01 PST 2016 > [INFO] Final Memory: 156M/1208M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Ajit Kumar > >
