----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43068/#review117300 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/api/services/VersionDefinitionService.java (lines 82 - 88) <https://reviews.apache.org/r/43068/#comment178460> I take it this is because we can't add non-JSON to the request handler, otherwise it'll complain about some parse error? Neat idea to make it base64'd and pass that value in a small JSON wrapper. Let's hope we don't run out of heap :) - Jonathan Hurley On Feb. 1, 2016, 5:24 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43068/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 5:24 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-14870 > https://issues.apache.org/jira/browse/AMBARI-14870 > > > Repository: ambari > > > Description > ------- > > Add an endpoint to allow posting of the Version Definition file directly. > The API doesn't like XML in json, so the body is base64'ed and added to a > json object that is then passed to the framework. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/VersionDefinitionService.java > 43eb424 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java > 3533293 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java > dbac1b4 > > Diff: https://reviews.apache.org/r/43068/diff/ > > > Testing > ------- > > Manual. Automated Pending. > > > Thanks, > > Nate Cole > >
