> On Feb. 1, 2016, 11:54 p.m., Alejandro Fernandez wrote: > > ambari-server/conf/unix/ambari.properties, line 80 > > <https://reviews.apache.org/r/43051/diff/2/?file=1228699#file1228699line80> > > > > For customers upgrading Ambari, should we add this value to their > > existing ambari.properties file? > > Robert Levas wrote: > Yikes... I already committed this but forgot to close the review. > > I thought this happens automagically if the property is in the _new_ > properties file. In anycase, there is no need to have this value in the > ambari.properties file if you are leaving it at `1200` since that is the > default value.
Not a big deal. I'm not sure what the behavior is on an upgrade or if there are related properties that achieve a similar effect. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43051/#review117307 ----------------------------------------------------------- On Feb. 1, 2016, 10:46 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43051/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 10:46 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton. > > > Bugs: AMBARI-14866 > https://issues.apache.org/jira/browse/AMBARI-14866 > > > Repository: ambari > > > Description > ------- > > Increase timeout for server-side tasks, or make the timeout configurable. > > This is to help in the case where environmental issues cause Kerberos-related > commands to take longer than usual, thus increasing the time it takes to > process Kerberos server-side actions. If the Kerberos-server side actions > timeout, Ambari fails the task and the user is stuck not able to perform the > desired Kerberos-related action. > > #Solution > Add property to ambari.properties (`server.task.timeout`, default value > `1200`) that is used to set the time out for server-side tasks. This value > will be used when setting up the stages for Kerberos and upgrade operations. > > > Diffs > ----- > > ambari-server/conf/unix/ambari.properties fd1b91e > ambari-server/conf/windows/ambari.properties 1dbc28a > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > d1453a0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > a0e6ccb > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 5a6a50d > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java > 00b8a74 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 67c0979 > > Diff: https://reviews.apache.org/r/43051/diff/ > > > Testing > ------- > > Manually tested > > # Local test results: PASSED > > # Jenkins test results: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:27 h > [INFO] Finished at: 2016-02-01T22:29:16+00:00 > [INFO] Final Memory: 136M/485M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
