[ 
https://issues.apache.org/jira/browse/AMBARI-14865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127442#comment-15127442
 ] 

Hadoop QA commented on AMBARI-14865:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12785615/rb43069.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/5145//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/5145//console

This message is automatically generated.

> Auto start: Maintenance mode of components should be respected when handling 
> agent registration.
> ------------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-14865
>                 URL: https://issues.apache.org/jira/browse/AMBARI-14865
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-agent, ambari-server
>    Affects Versions: 2.4.0
>            Reporter: Nahappan Somasundaram
>            Assignee: Nahappan Somasundaram
>              Labels: ambari-agent, ambari-server
>             Fix For: 2.4.0
>
>         Attachments: rb43069.patch
>
>
> Even if a service or component is set to auto start but is in maintenance 
> mode, it should not auto start. Components in maintenance mode (because 
> host/service is in maintenance mode) should not be enabled for auto start.
> Current implementation:
> In the current implementation we have both enabledComponents and 
> disabledComponents. To determine if a specified component is enabled for 
> recovery, an inclusive and exclusive test against enabledComponents and 
> disabledComponents is used. There is no support for excluding a component in 
> maintenance since that state is not available to the agent.
> To determine if a component marked for auto start is in maintenance state, 
> it's maintenance state has to be queried from the server, which makes it 
> cumbersome and agent managed. 
> New design:
> 1. Components to be enabled for auto start must be explicitly specified as 
> comma separated values in the enabledComponents section of the recovery 
> configuration. 
> 2. During agent registration, the server will determine if each of the 
> components marked for auto start is in maintenance mode or not and filter the 
> list before sending the list (enabledComponents) in the recovery 
> configuration to the agent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to