[ 
https://issues.apache.org/jira/browse/AMBARI-14880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128581#comment-15128581
 ] 

Hadoop QA commented on AMBARI-14880:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12785795/AMBARI-14880.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-admin ambari-web.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/5156//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/5156//console

This message is automatically generated.

> Add popup that will show desired messages upon login
> ----------------------------------------------------
>
>                 Key: AMBARI-14880
>                 URL: https://issues.apache.org/jira/browse/AMBARI-14880
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-web
>    Affects Versions: 2.4.0
>            Reporter: Antonenko Alexander
>            Assignee: Antonenko Alexander
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-14880.patch
>
>
> Treat this just as remark:
> We should show this message during page load (view in iframe can be still in 
> loading state),
> because if we will show it after page will be fully rendered, that will 
> require integration to 
> each view. And this is what we definitely don't want to do.
> Because if not logged in user will enter link like
> http://CLUSTER ADDRESS/#/main/views/SLIDER/2.0.0/test, he will be redirected 
> to 
> login page, after he will enter credential, he will be redirected to view 
> that was initially 
> in url /main/views/SLIDER/2.0.0/test. 
> So the url that he entered before login will be loaded. 
> And there is no way, we can determine from ambari, that view inside iframe 
> loaded all 
> needed resources



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to