-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43146/
-----------------------------------------------------------
(Updated Feb. 4, 2016, 9:38 a.m.)
Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
Changes
-------
Changed returned value of `getForceToggleKerberosDirective` from `Boolean` to
`boolean`
Bugs: AMBARI-14905
https://issues.apache.org/jira/browse/AMBARI-14905
Repository: ambari
Description
-------
Add an API directive to force toggling Kerberos if the cluster's security type
has not changed.
This is useful for _retry_ attempts to enable or disable Kerberos when the
workflow progressed far enough to store the _new_ security type.
Trying to enable Kerberos when the cluster's security type is already set to
`KERBEROS` will result in a successful response from the Ambari server but no
actions will be performed. Same for attempting to disable Kerberos when the
cluster's security type is already set to `NONE`.
By forcing the operation using the `force_toggle_kerberos=true` directive, the
security type check is avoided, thus allowing the _retry_ operation to proceed.
Example:
```
PUT /api/v1/clusters/CLUSTER_NAME?force_toggle_kerberos=true
{
"Clusters" : {
"security_type" : "KERBEROS"
}
}
```
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
b2be291
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
5010311
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
5008d60
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
63aa92d
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
5838001
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
869d187
Diff: https://reviews.apache.org/r/43146/diff/
Testing
-------
Manually tested (via API calls)
# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 57:10.059s
[INFO] Finished at: Wed Feb 03 15:24:15 EST 2016
[INFO] Final Memory: 71M/1409M
[INFO] ------------------------------------------------------------------------
# Jenkins test results: PENDING
Thanks,
Robert Levas
