> On Feb. 5, 2016, 4:36 p.m., Alexandr Antonenko wrote: > > ambari-web/app/views/common/quick_view_link_view.js, line 443 > > <https://reviews.apache.org/r/43189/diff/1/?file=1232165#file1232165line443> > > > > Why are you making a compare with null ? I do not see any posible way > > oozieHostsArray can get null value
Right, I removed the unecessary check. Thanks Alex. - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43189/#review118026 ----------------------------------------------------------- On Feb. 5, 2016, 2:39 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43189/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 2:39 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Jaimin Jetly. > > > Bugs: AMBARI-14871 > https://issues.apache.org/jira/browse/AMBARI-14871 > > > Repository: ambari > > > Description > ------- > > It currently says "Hostname is undefined". This JIRA is to update the logic a > little bit in an attempt to display better error messages. > > > Diffs > ----- > > ambari-web/app/messages.js 8861b2a > ambari-web/app/templates/main/service/item.hbs f61695e > ambari-web/app/views/common/quick_view_link_view.js c2f7dcc > ambari-web/test/views/common/quick_link_view_test.js 93a235c > > Diff: https://reviews.apache.org/r/43189/diff/ > > > Testing > ------- > > unit test > > manually patch a cluster and test the error message when oozie server is > stopped. > > > Thanks, > > Di Li > >
