-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43268/
-----------------------------------------------------------

Review request for Ambari and Alexandr Antonenko.


Bugs: AMBARI-14846
    https://issues.apache.org/jira/browse/AMBARI-14846


Repository: ambari


Description
-------

If you have multiple errors related to missing dependencies and you cancel 
before you reach the last error, the isAccepted flag is false for at least one 
of the objects in the errorStack array. As a result, selection of any of the 
missing dependencies does not clear the errorStack array and the error message 
for the missing dependencies still persists in the array.


Diffs
-----

  ambari-web/app/controllers/wizard/step4_controller.js 90479ac 
  ambari-web/test/controllers/wizard/step4_test.js 80667c9 

Diff: https://reviews.apache.org/r/43268/diff/


Testing
-------

Fix involves clearing error object corresponding to a required service check if 
the service is found to be selected during service dependency validation. 
Similar fix for Ranger, Ambari Metrics, Spark and multipleDFS errors.

Manual testing. Also added new test case for testing contents of errorStack 
array after serviceDependencyValidation method is called before and after a 
required service is selected.

mvn clean test

24102 tests complete (32 seconds)
166 tests pending


Thanks,

Sangeeta Ravindran

Reply via email to