> On Feb. 8, 2016, 1:59 p.m., Sumit Mohanty wrote: > > ambari-common/src/main/python/ambari_commons/os_check.py, line 87 > > <https://reviews.apache.org/r/43326/diff/1/?file=1237168#file1237168line87> > > > > Is /etc/issue standard? Just that the file name issue seems little odd. > > How about /etc/os-release or /etc/system-release? > > Andrew Onischuk wrote: > I saw /etc/issue on every single system ubuntu,suse,debian,centos,amazon. > It seems to be pretty standart.
What I read from web and "man issue" is that it is a file that may be edited for custom login messages. So is it relaible? /etc/os-release, at least based on the name, seems to be a better choice? > On Feb. 8, 2016, 1:59 p.m., Sumit Mohanty wrote: > > ambari-server/conf/unix/install-helper.sh, line 71 > > <https://reviews.apache.org/r/43326/diff/1/?file=1237174#file1237174line71> > > > > Same as the prior comment for ambari-agent. Why was this needed? > > Andrew Onischuk wrote: > it picked python2.6 which is not system-default, and didn't have 'import > rpm ; import yum', and caused failures on install on components. I changed > the logics to use /usr/bin/python which is a system default python , and not > /usr/bin/python2 as before. But since python can be python3, we have do to a > check for version, using previous logics would involve checking it with every > call in ambari-python-wrap (the one which was a file chooser, not a link) > which would slow down every of those calls. Makes sense. > On Feb. 8, 2016, 1:59 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/repos/repoinfo.xml, line 32 > > <https://reviews.apache.org/r/43326/diff/1/?file=1237180#file1237180line32> > > > > Could we have avoided introducing a new family and mapping amazon2015 > > to say rhel6? > > Andrew Onischuk wrote: > We could put them in the same family if they had the same versioning like > oraclelinux and redhat and centos, but since the version is different, doing > such is not something we cannot do cleanly without hacking, and adding a > mapping for those versions somewhere. The OS mapping excercise is interpreting a file and normalizing content using OS specific logic. So mappinng 2015 to 6 will be more of the same. Also, the current solution will not automatically add support for 2016/2017 etc without more change. I would vote for reducing number of files to change and not adding extra section to metainfo/repoinfo xml files considering Amazon linux is equivalent to rhel/centos. - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43326/#review118224 ----------------------------------------------------------- On Feb. 8, 2016, 11:24 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43326/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 11:24 a.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-14953 > https://issues.apache.org/jira/browse/AMBARI-14953 > > > Repository: ambari > > > Description > ------- > > Support Ambari Server/Agent and HDP install on Amazon Linux. > > The issues which got fixed in the patch: > 1. Python version was choosen incorrectly, causing install failures. > 2. Postgresql data dir was choosen incorrectly, causing ambari-server start > and setup to fail. > 3. Improve os_check.py to be able to detect amazon os > 4. Add the entries for amazon2015 to repoinfo,xml and metainfo.xml, rmf. > > > Diffs > ----- > > ambari-agent/conf/unix/ambari-agent 50d13b1 > ambari-agent/conf/unix/install-helper.sh 35c67fb > ambari-agent/pom.xml 38f436e > ambari-common/src/main/python/ambari_commons/os_check.py 904a23b > ambari-common/src/main/python/ambari_commons/resources/os_family.json > c0acc2c > > ambari-common/src/main/python/resource_management/core/providers/__init__.py > abb51c3 > > ambari-common/src/main/python/resource_management/libraries/providers/__init__.py > 44e9ca1 > ambari-common/src/main/unix/ambari-python-wrap 8dab946 > ambari-server/conf/unix/ambari-env.sh e463ca6 > ambari-server/conf/unix/install-helper.sh 9dbb2b8 > ambari-server/pom.xml f129983 > ambari-server/sbin/ambari-server 47e2926 > ambari-server/src/main/python/ambari_server/utils.py 2afcd1b > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml > 6ea4ca5 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml > 72f159a > ambari-server/src/main/resources/stacks/HDP/2.2/repos/repoinfo.xml dbf8506 > ambari-server/src/main/resources/stacks/HDP/2.3/repos/repoinfo.xml 142b87d > > ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/metainfo.xml > 352341b > ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml > fee10d3 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/metainfo.xml > 6fdad8b > ambari-server/src/main/resources/stacks/HDP/2.3/services/FLUME/metainfo.xml > 5031f85 > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/metainfo.xml > 90a31f5 > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml > ca69195 > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/metainfo.xml > 0756a54 > ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/metainfo.xml > 330b542 > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/metainfo.xml > d1172b1 > ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/metainfo.xml > ccf5de3 > ambari-server/src/main/resources/stacks/HDP/2.3/services/PIG/metainfo.xml > 8ba2426 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml > 2fb8a9a > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER_KMS/metainfo.xml > 5606a26 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/SLIDER/metainfo.xml > 8287b50 > ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml > 2c9680c > ambari-server/src/main/resources/stacks/HDP/2.3/services/SQOOP/metainfo.xml > 1290cde > ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/metainfo.xml > 00af620 > ambari-server/src/main/resources/stacks/HDP/2.3/services/TEZ/metainfo.xml > 7720a3d > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/metainfo.xml > 5a21200 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/ZOOKEEPER/metainfo.xml > 1f77215 > ambari-server/src/main/resources/stacks/HDP/2.4/repos/repoinfo.xml 54bd3da > > ambari-server/src/main/resources/stacks/HDP/2.4/services/ACCUMULO/metainfo.xml > 9e82a82 > ambari-server/src/main/resources/stacks/HDP/2.4/services/ATLAS/metainfo.xml > 158ef8c > > ambari-server/src/main/resources/stacks/HDP/2.4/services/FALCON/metainfo.xml > 183d55c > ambari-server/src/main/resources/stacks/HDP/2.4/services/FLUME/metainfo.xml > b7cd3d1 > ambari-server/src/main/resources/stacks/HDP/2.4/services/HBASE/metainfo.xml > a1c2bd0 > ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/metainfo.xml > ce3fb95 > ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/metainfo.xml > 5ad52b6 > ambari-server/src/main/resources/stacks/HDP/2.4/services/KAFKA/metainfo.xml > 90bc472 > ambari-server/src/main/resources/stacks/HDP/2.4/services/KNOX/metainfo.xml > e465d42 > ambari-server/src/main/resources/stacks/HDP/2.4/services/OOZIE/metainfo.xml > 2f09e88 > ambari-server/src/main/resources/stacks/HDP/2.4/services/PIG/metainfo.xml > 9ae1f42 > > ambari-server/src/main/resources/stacks/HDP/2.4/services/RANGER/metainfo.xml > d76ad5c > > ambari-server/src/main/resources/stacks/HDP/2.4/services/RANGER_KMS/metainfo.xml > a27bf31 > > ambari-server/src/main/resources/stacks/HDP/2.4/services/SLIDER/metainfo.xml > ff998f0 > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml > 13c6a9b > ambari-server/src/main/resources/stacks/HDP/2.4/services/SQOOP/metainfo.xml > 721cc33 > ambari-server/src/main/resources/stacks/HDP/2.4/services/STORM/metainfo.xml > 36b01e4 > ambari-server/src/main/resources/stacks/HDP/2.4/services/TEZ/metainfo.xml > 356225e > ambari-server/src/main/resources/stacks/HDP/2.4/services/YARN/metainfo.xml > c61a270 > > ambari-server/src/main/resources/stacks/HDP/2.4/services/ZOOKEEPER/metainfo.xml > 4bf4198 > > Diff: https://reviews.apache.org/r/43326/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
