----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42712/#review118366 -----------------------------------------------------------
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js (line 316) <https://reviews.apache.org/r/42712/#comment179605> Can we make this logic simpler. Is there a reason behind converting the array into a different form? - Sreenath Somarajapuram On Feb. 8, 2016, 10:20 a.m., Akhil PB wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42712/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 10:20 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-14753 > https://issues.apache.org/jira/browse/AMBARI-14753 > > > Repository: ambari > > > Description > ------- > > Added effective permissions for acl_submit_application and > acl_administer_queue in capshed. > > > Diffs > ----- > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js > 521b473 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > c0acf4f > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs > 15550d1 > > Diff: https://reviews.apache.org/r/42712/diff/ > > > Testing > ------- > > Done some manual unit testing in both ambari operator and non-operator mode. > > > Thanks, > > Akhil PB > >
