> On Feb. 10, 2016, 1:11 a.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java, > > line 1251 > > <https://reviews.apache.org/r/43385/diff/1/?file=1239038#file1239038line1251> > > > > What if user specfied a value less than a day in seconds.
I think defaulting to "1" day for seconds value < 86400 is reasonable. - Aravindan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43385/#review118526 ----------------------------------------------------------- On Feb. 10, 2016, 5:13 a.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43385/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 5:13 a.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-14982 > https://issues.apache.org/jira/browse/AMBARI-14982 > > > Repository: ambari > > > Description > ------- > > Enhancements in this patch. > > 1. Set precision table TTL to 1day/7days based on embedded/distributed mode. > 2. Disable TimelineMetricStoreWatcher in distributed mode. > 3. Change AMS HBase tables TTL config values to DAYS instead of SECONDS. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > 5ee8b44 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > 71e65f7 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java > a1a0c5d > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java > 7e2683d > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml > 3391943 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > b4bb68f > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java > 913b08d > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 904688a > > Diff: https://reviews.apache.org/r/43385/diff/ > > > Testing > ------- > > Manual testing done for stack_advisor and TTL units changes. > > ambari-metrics unit tests pass. > > Upgrade Testing in progress. > > > Thanks, > > Aravindan Vijayan > >
